[
https://issues.apache.org/jira/browse/GEODE-3961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16251814#comment-16251814
]
ASF GitHub Bot commented on GEODE-3961:
---------------------------------------
PurelyApplied commented on issue #1046: GEODE-3961: Refactor ShowMetricsCommand
to behave uniformly...
URL: https://github.com/apache/geode/pull/1046#issuecomment-344339762
@jdeppe-pivotal @jinmeiliao I believe the `port` autocomplete is provided by
the `Converter` for the type expected. The `String` converter has no
autocomplete, and it looks like the `Integer` converter is suggesting "write a
number here!"
We could introduce a `Port` class that wraps `Integer` and provides more
meaningful information for autocomplete via a different `Converter`, but that
seems to me to be an improvement beyond the scope of this ticket.
So the question is: should I leave it `String` for now, with plans to move
to a `Port` type down the road, or should it be an `Integer`, even if the
autocomplete is less than meaningful?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Show metrics disregards specified --categories for CacheServer (--port option
> related) metrics
> -----------------------------------------------------------------------------------------------
>
> Key: GEODE-3961
> URL: https://issues.apache.org/jira/browse/GEODE-3961
> Project: Geode
> Issue Type: Bug
> Reporter: Patrick Rhomberg
>
> Those CacheServer metric categories ({{query}}, {{notification}}, and
> {{cache-server}}) are not checked against those categories specified by the
> user and are only checked against the cache server bean being non-null
> (implicitly: that the port was provided and valid).
> For unification and consistency, these categories should not be displayed
> when the {{--categories}} option is specified and excludes them.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
