[
https://issues.apache.org/jira/browse/GEODE-3539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16246648#comment-16246648
]
ASF GitHub Bot commented on GEODE-3539:
---------------------------------------
pdxrunner commented on a change in pull request #1040: GEODE-3539: cleanup
GfshCommand and refactor tests
URL: https://github.com/apache/geode/pull/1040#discussion_r150099937
##########
File path:
geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/StartLocatorCommandTest.java
##########
@@ -144,4 +159,55 @@ private void addJvmOptionsForOutOfMemoryErrors(final
List<String> commandLine) {
commandLine.add("-XXexitOnOutOfMemory");
}
}
+
+ private static final String FAKE_HOSTNAME = "someFakeHostname";
+
+ @Rule
+ public GfshParserRule commandRule = new GfshParserRule();
+
+ @Rule
+ public ExpectedException thrown = ExpectedException.none();
+
+ @Rule
+ public TemporaryFolder temporaryFolder = new TemporaryFolder();
+
+ private StartLocatorCommand spy;
+
+ @Before
+ public void before() throws Exception {
+ spy = Mockito.spy(StartLocatorCommand.class);
+ doReturn(mock(Gfsh.class)).when(spy).getGfsh();
+ }
+
Review comment:
I'd prefer to see these new @Rule & @Before methods moved to the top of the
file with the original @Before method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add more test coverage for p2p commands
> ---------------------------------------
>
> Key: GEODE-3539
> URL: https://issues.apache.org/jira/browse/GEODE-3539
> Project: Geode
> Issue Type: Improvement
> Components: gfsh
> Reporter: Jinmei Liao
>
> Add more command tests that would eventually get rid of the legacy tests.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
