[
https://issues.apache.org/jira/browse/GEODE-3421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16245220#comment-16245220
]
ASF GitHub Bot commented on GEODE-3421:
---------------------------------------
pivotal-jbarrett commented on a change in pull request #145: GEODE-3421:
Cleanup public API headers
URL: https://github.com/apache/geode-native/pull/145#discussion_r149869296
##########
File path: cppcache/test/CacheableStringEqualityTest.cpp
##########
@@ -21,9 +21,10 @@
#include <unordered_set>
#include <unordered_map>
-#include <geode/utils.hpp>
#include <geode/CacheableString.hpp>
+#include "util/functional.hpp"
Review comment:
While I like the rename, I think this one header should probably remain
public. It provides the hash and equal_to for dereferenced `shared_ptr`objects.
It could be quite helpful. Though I suppose we can move it public later if
people are asking for it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Public API Removals
> -------------------
>
> Key: GEODE-3421
> URL: https://issues.apache.org/jira/browse/GEODE-3421
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Reporter: Addison
>
> Move the following out of the public API:
> - CacheTransactionmanager2PC
> - Log.hpp
> - utils.hpp
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
