[
https://issues.apache.org/jira/browse/GEODE-3938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16234050#comment-16234050
]
ASF GitHub Bot commented on GEODE-3938:
---------------------------------------
jujoramos opened a new pull request #1003: Fix for GEODE-3938
URL: https://github.com/apache/geode/pull/1003
GEODE-3938: Allow query parameters within the to_date preset query function.
. Added unit tests.
. Changed oql.g to allow both 'stringLiteral' and 'queryParam' within the
do_date preset function definition.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [X] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [X] Is your initial contribution a single, squashed commit?
- [X] Does `gradlew build` run cleanly?
- [X] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to [email protected].
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Allow query parameters within the to_date preset query function
> ---------------------------------------------------------------
>
> Key: GEODE-3938
> URL: https://issues.apache.org/jira/browse/GEODE-3938
> Project: Geode
> Issue Type: New Feature
> Components: querying
> Reporter: Juan José Ramos Cassella
> Assignee: Juan José Ramos Cassella
>
> Currently the {{to_date}} preset query function doesn't allow the user to
> pass the date to format as a query parameter, which forces the user
> application to add boilerplate code to manually parse the date.
> Apparently there's no internal blockers preventing such a feature to be
> enabled, and the change just implies a small change in {{oql.g}}:
> {code}
> conversionExpr :
> (
> ...
> |
> (
> (
>
> "to_date"^<AST=org.apache.geode.cache.query.internal.parse.ASTConversionExpr>
> )
> TOK_LPAREN!
> (stringLiteral | queryParam) TOK_COMMA! stringLiteral
> TOK_RPAREN!
> )
> ...
> )
> ;
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
