[
https://issues.apache.org/jira/browse/GEODE-3539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16225646#comment-16225646
]
ASF GitHub Bot commented on GEODE-3539:
---------------------------------------
jdeppe-pivotal commented on a change in pull request #992: GEODE-3539:
Consolidate CliUtil and DataCommandUtils, DataCommandsUtil
URL: https://github.com/apache/geode/pull/992#discussion_r147811482
##########
File path:
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/GemfireDataCommandsDUnitTest.java
##########
@@ -589,14 +588,14 @@ public void doTestBug48013() {
public void testSelectCommand() {
setupForSelect();
doTestGetRegionAssociatedMembersForSelect();
- doTestSelectWithGfshEnvVariables(true);
- doTestSelectWithGfshEnvVariables(false);
- doTestSelectProjection();
- doTestBug48013();
- doTestSelectProjectionProcessCommand();
- doTestSelectProjectionWithNestedField();
- doTestSelectBeansAsResult();
- doTestSelectBeansWithNestedFieldAsResult();
+ // doTestSelectWithGfshEnvVariables(true);
+ // doTestSelectWithGfshEnvVariables(false);
+ // doTestSelectProjection();
+ // doTestBug48013();
+ // doTestSelectProjectionProcessCommand();
+ // doTestSelectProjectionWithNestedField();
+ // doTestSelectBeansAsResult();
+ // doTestSelectBeansWithNestedFieldAsResult();
Review comment:
Can these be deleted? If they need to stay, could you add a comment as to
why they're commented out.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add more test coverage for p2p commands
> ---------------------------------------
>
> Key: GEODE-3539
> URL: https://issues.apache.org/jira/browse/GEODE-3539
> Project: Geode
> Issue Type: Improvement
> Components: gfsh
> Reporter: Jinmei Liao
>
> Add more command tests that would eventually get rid of the legacy tests.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
