[
https://issues.apache.org/jira/browse/GEODE-2719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16148928#comment-16148928
]
ASF GitHub Bot commented on GEODE-2719:
---------------------------------------
GitHub user ameybarve15 opened a pull request:
https://github.com/apache/geode/pull/751
GEODE-2719 : Deprecated setTotalMaxMemory and getTotalMaxMemory and updated
their javadocs.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [X] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [X] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to [email protected].
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ameybarve15/incubator-geode feature/GEODE-2719
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/751.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #751
----
commit f605e26aaf3d3d667dcc2911c5bd944c41d4512f
Author: Amey Barve <[email protected]>
Date: 2017-08-31T10:08:08Z
GEODE-2719: Deprecated setTotalMaxMemory and getTotalMaxMemory and
updated their javadocs.
commit 303bb99a2af9e72f91be0163f8f3dce0ec2dffde
Author: Amey Barve <[email protected]>
Date: 2017-08-31T12:06:54Z
GEODE-2719: corrected GEODE versions to 1.3.0 instead of 1.2.2 for the
respective deprecated API javadocs.
----
> The total-max-memory region attribute does not appear to do anything
> --------------------------------------------------------------------
>
> Key: GEODE-2719
> URL: https://issues.apache.org/jira/browse/GEODE-2719
> Project: Geode
> Issue Type: Improvement
> Components: docs, regions
> Reporter: Darrel Schneider
> Assignee: Amey Barve
> Labels: storage_3
>
> I could not find that the "total-max-memory" region partitioned attribute
> does anything. If this is correct then it should be deprecated and removed in
> a future release. A user read the geode docs and expected it cause LRU
> eviction since this docs say this about it:
> {quote}
> Maximum combined megabytes of memory to be used by all processes hosting this
> region for all copies, primary and redundant.
> {quote}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
