[
https://issues.apache.org/jira/browse/GEODE-3503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16140951#comment-16140951
]
ASF GitHub Bot commented on GEODE-3503:
---------------------------------------
Github user pivotal-amurmann commented on a diff in the pull request:
https://github.com/apache/geode/pull/737#discussion_r135156514
--- Diff:
geode-protobuf/src/test/java/org/apache/geode/protocol/RoundTripCacheConnectionJUnitTest.java
---
@@ -119,7 +119,14 @@ public void setup() throws Exception {
}
CacheFactory cacheFactory = new CacheFactory(properties);
- cacheFactory.set("mcast-port", "0"); // sometimes it isn't due to
other tests.
+ cacheFactory.set(ConfigurationProperties.MCAST_PORT, "0"); //
sometimes it isn't due to other
+ // tests.
+ cacheFactory.set(ConfigurationProperties.ENABLE_CLUSTER_CONFIGURATION,
"false"); // sometimes it
+
// isn't due to
+
// other tests.
--- End diff --
I realize this is following existing style, but could we be more explicit
in the comment and say what `it isn't`? Something like `sometimes it is not set
to "false" due to test pollution` would be clearer. Or Even just `guard against
test pollution`. II had to read the comment multiple times to understand what
was going on.
> Remove Codec classes for Protobuf encoded primitives
> ----------------------------------------------------
>
> Key: GEODE-3503
> URL: https://issues.apache.org/jira/browse/GEODE-3503
> Project: Geode
> Issue Type: Sub-task
> Components: client/server
> Reporter: Udo Kohlmeyer
> Assignee: Udo Kohlmeyer
>
> As per the initial implementation, the client protocol would encode all
> primitives using specified codecs. To improve on this, all primitives are now
> encoded using protobuf and the codec classes are not required anymore and can
> be removed.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
