[ 
https://issues.apache.org/jira/browse/GEODE-3508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16138766#comment-16138766
 ] 

ASF GitHub Bot commented on GEODE-3508:
---------------------------------------

GitHub user PurelyApplied opened a pull request:

    https://github.com/apache/geode/pull/734

    GEODE-3508: Remove unused internal deprecated classes.

    * Update ClusterConfigurationNotAvailableException to extend Exception 
directly, rather than the deprecated class.
    
    ------
    
    Thank you for submitting a contribution to Apache Geode.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?
    
    - [x] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    - [x] Does `gradlew build` run cleanly?
    
    - [n/a] Have you written or updated unit tests to verify your changes?
    
    - [n/a] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
    submit an update to your PR as soon as possible. If you need help, please 
send an
    email to [email protected].


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/PurelyApplied/geode geode-3508

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/734.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #734
    
----
commit 86e6daf53fa1660ea4744415a3d9f613f4b5a3f5
Author: Patrick Rhomberg <[email protected]>
Date:   2017-08-23T17:49:32Z

    GEODE-3508: Remove three unused internal deprecated classes.
    
    * Update ClusterConfigurationNotAvailableException to extend Exception 
directly, rather than the deprecated class.

----


> Removed unused internal deprecated classes.
> -------------------------------------------
>
>                 Key: GEODE-3508
>                 URL: https://issues.apache.org/jira/browse/GEODE-3508
>             Project: Geode
>          Issue Type: Improvement
>            Reporter: Patrick Rhomberg
>
> The following classes are internal, deprecated, and (essentially) unused.
> {noformat}
> geode-core/src/main/java/org/apache/geode/distributed/internal/MessageFactory.java
> geode-core/src/main/java/org/apache/geode/internal/process/ClusterConfigurationNotAvailableException.java
> geode-core/src/main/java/org/apache/geode/management/internal/configuration/utils/DtdResolver.java
> {noformat}
> They may be safely deleted.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to