[
https://issues.apache.org/jira/browse/GEODE-3276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16137573#comment-16137573
]
ASF GitHub Bot commented on GEODE-3276:
---------------------------------------
Github user jhuynh1 commented on a diff in the pull request:
https://github.com/apache/geode/pull/732#discussion_r134622619
--- Diff:
geode-wan/src/main/java/org/apache/geode/internal/cache/wan/parallel/ParallelGatewaySenderImpl.java
---
@@ -107,6 +107,9 @@ public void stop() {
if (ev != null && !ev.isStopped()) {
ev.stopProcessing();
}
+ if (ev != null && ev.getDispatcher() != null) {
--- End diff --
Is it possible to pull this check and shutdown into a method? Looks like
it's used a few times throughout the code
> CI failure:
> org.apache.geode.internal.cache.wan.parallel.ParallelWANStatsDUnitTest >
> testParallelPropagationWithRemoteRegionDestroy FAILED
> ------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: GEODE-3276
> URL: https://issues.apache.org/jira/browse/GEODE-3276
> Project: Geode
> Issue Type: Bug
> Components: statistics, wan
> Affects Versions: 1.2.0
> Reporter: Shelley Lynn Hughes-Godfrey
> Assignee: nabarun
>
> {noformat}
> org.apache.geode.internal.cache.wan.parallel.ParallelWANStatsDUnitTest >
> testParallelPropagationWithRemoteRegionDestroy FAILED
> java.lang.AssertionError: An exception occurred during asynchronous
> invocation.
> Caused by:
> java.lang.OutOfMemoryError: Java heap space
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)