[
https://issues.apache.org/jira/browse/GEODE-3184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133587#comment-16133587
]
ASF GitHub Bot commented on GEODE-3184:
---------------------------------------
GitHub user DivineEnder opened a pull request:
https://github.com/apache/geode/pull/722
GEODE-3184: Cleaned up Cargo tests
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to [email protected].
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DivineEnder/geode feature/GEODE-3184
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/722.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #722
----
commit b47c7fd5491bf4725005d4ea57aa6192df6176cc
Author: David Anuta <[email protected]>
Date: 2017-08-18T16:41:24Z
GEODE-3184: Cleaned up Cargo tests
----
> Clean up session replication testing
> ------------------------------------
>
> Key: GEODE-3184
> URL: https://issues.apache.org/jira/browse/GEODE-3184
> Project: Geode
> Issue Type: Improvement
> Components: http session
> Reporter: David Anuta
> Assignee: David Anuta
> Priority: Minor
>
> Would be good to review the code base and make sure methods are properly
> organized.
> Also, the previous session replication testing is still in place in the
> extensions folder. This needs to be reviewed and any tests not covered by
> cargo should be transferred over into the new cargo replication testing. An
> example of something within this that needs to be cleaned up would be
> QueryCommand and CommandServlet classes, which are both in the
> extensions/geode-modules and extensions/session-testing-war projects. the
> QueryCommand and Command Servlet class within the extensions/geode-modules
> project could be removed if the previous session tests were all ported to
> cargo and then removed.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
