[jira] [Created] (GEODE-3438) Collection added to itself

[JC (JIRA)]

JC created GEODE-3438:
-------------------------

             Summary: Collection added to itself
                 Key: GEODE-3438
                 URL: https://issues.apache.org/jira/browse/GEODE-3438
             Project: Geode
          Issue Type: Bug
          Components: core
            Reporter: JC


Hi

In a recent github mirror, I've found suspicious code.
Branch: master
Path: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/domain/DurableCqNamesResult.java

{code:java}
...
 27   private List<String> cqNames = new ArrayList<String>();
...
 33   public DurableCqNamesResult(final String memberNameOrId, List<String> 
cqNames) {
 34     super(memberNameOrId);
 35     cqNames.addAll(cqNames);
 36   }
{code}

In Line 35, should `cqNames.addAll' be `this.cqNames.addAll'? This might not be 
an issue, but I wanted to report just in case.

Thanks!



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)