[
https://issues.apache.org/jira/browse/GEODE-3386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16125956#comment-16125956
]
ASF GitHub Bot commented on GEODE-3386:
---------------------------------------
Github user pivotal-amurmann commented on a diff in the pull request:
https://github.com/apache/geode/pull/700#discussion_r133001811
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/PutAllRequestOperationHandler.java
---
@@ -79,9 +81,10 @@
private BasicTypes.KeyedErrorResponse
buildAndLogKeyedError(BasicTypes.Entry entry,
ProtocolErrorCode errorCode, String message, Exception ex) {
logger.error(message, ex);
- BasicTypes.ErrorResponse errorResponse =
BasicTypes.ErrorResponse.newBuilder()
- .setErrorCode(errorCode.codeValue).setMessage(message).build();
- return
BasicTypes.KeyedErrorResponse.newBuilder().setKey(entry.getKey()).setError(errorResponse)
+
+ return
BasicTypes.KeyedErrorResponse.newBuilder().setKey(entry.getKey())
+ .setError(
+
BasicTypes.Error.newBuilder().setErrorCode(errorCode.codeValue).setMessage(message))
--- End diff --
yeah it did 😔
Tried to reformat it, but it insists on making this bad.
> Create Error type for KeyedErrorResponse and ErrorResponse
> ----------------------------------------------------------
>
> Key: GEODE-3386
> URL: https://issues.apache.org/jira/browse/GEODE-3386
> Project: Geode
> Issue Type: Sub-task
> Components: client/server
> Reporter: Galen O'Sullivan
>
> For logical separation of the new client API, it will be better to have an
> Error that is contained by ErrorResponse, rather than having
> KeyedErrorResponse contain an ErrorResponse.
> In pseudo-protobuf,
> {code}
> PutAllResponse {
> repeated Entry successes = 1,
> repeated KeyedErrorResponse errors = 2,
> }
> KeyedErrorResponse {
> Key,
> ErrorResponse
> }
> ErrorResponse {
> string
> }
> {code}
> instead,
> {code}
> KeyedErrorResponse {
> Key,
> Error,
> }
> {code}
> and
> {code}
> ErrorResponse {
> Error
> }
> Error {
> string
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
