[ 
https://issues.apache.org/jira/browse/GEODE-3077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16102300#comment-16102300
 ] 

Galen O'Sullivan commented on GEODE-3077:
-----------------------------------------

The C# driver team reports that connections using the new protocol aren't being 
closed; this is likely related.

> Make sure that AcceptorImpl's connection count is upheld.
> ---------------------------------------------------------
>
>                 Key: GEODE-3077
>                 URL: https://issues.apache.org/jira/browse/GEODE-3077
>             Project: Geode
>          Issue Type: Sub-task
>          Components: client/server
>            Reporter: Galen O'Sullivan
>
> Have a look at where and how the following three functions are used:
> {code}
>   public void incClientServerCnxCount() {
>     this.clientServerCnxCount.incrementAndGet();
>   }
>   public void decClientServerCnxCount() {
>     this.clientServerCnxCount.decrementAndGet();
>   }
>   public int getClientServerCnxCount() {
>     return this.clientServerCnxCount.get();
>   }
> {code}
> These are tracking client-server connections. Extract these into common code 
> in {{ServerConnection}} that both {{NewClientServerConnection}} and 
> {{LegacyServerConnection}} can use, and make sure that counts are correct in 
> both creation and cleanup situations. Write some tests to verify.
> Note: client counts look to be tracked separately from connection counts; the 
> old protocol can have multiple connections per client. We're interested with 
> the connection count in this ticket.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to