[
https://issues.apache.org/jira/browse/GEODE-2997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16096763#comment-16096763
]
ASF GitHub Bot commented on GEODE-2997:
---------------------------------------
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/649#discussion_r128847166
--- Diff: geode-protobuf/src/main/proto/clientProtocol.proto ---
@@ -66,7 +66,7 @@ message Response {
RemoveAllResponse removeAllResponse = 7;
ListKeysResponse listKeysResponse = 8;
- ErrorResponse errorResponse = 13;
+ Error error = 13;
--- End diff --
Why has this been renamed to Error from ErrorResponse? Imo, we are
following the pattern (good or bad) that a ClientProtocol.Response contains an
Operation specific response. To now have a non-"Response" message sort of
breaks the mold.
> New flow: putAll/getAll
> -----------------------
>
> Key: GEODE-2997
> URL: https://issues.apache.org/jira/browse/GEODE-2997
> Project: Geode
> Issue Type: Sub-task
> Components: client/server
> Reporter: Brian Baynes
>
> Create proto message definitions and op handler for putAll/getAll messages.
> Client should be able to complete putAll/getAll of primitives and JSON with
> response.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
