[
https://issues.apache.org/jira/browse/GEODE-3187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16090783#comment-16090783
]
Darrel Schneider commented on GEODE-3187:
-----------------------------------------
This failure revealed a couple of problems with the Windows specific backup
code.
1. The BackupInspectionJUnitTest hard codes the contents of the restore scripts
in a couple of java String constants. These String have diverged and no longer
contain restore scripts that geode backup command will generate. The ones that
are wrong are:
org.apache.geode.internal.cache.persistence.BackupInspectorJUnitTest.WINDOWS_INCREMENTAL_BACKUP_SCRIPT
org.apache.geode.internal.cache.persistence.BackupInspectorJUnitTest.WINDOWS_FULL_BACKUP_SCRIPT
Both of them contain "xcopy" and "copy" but the backup code now uses "robocopy"
instead.
2. The method:
org.apache.geode.internal.cache.persistence.WindowsBackupInspector.parseOplogLines(BufferedReader)
ask this: line.startsWith("robocopy")
But the code that generates these lines add this to the start of a line:
"C:\\Windows\\System32\\Robocopy.exe". So it is never going to find "robocopy"
and this will cause the inspector to never detect an incremental backup.
I think instead of looking for lines that start with "robocopy" it should just
skip lines that start with "IF" and break if it contains EXIT_MARKER (it
already does both of these). For any other line it should extract the oplog
file name. This is basically what it does for linux.
3. It seems wrong for the backup command to generate
"C:\\Windows\\System32\\Robocopy.exe". I could be wrong but I doubt that
robocopy will always be in this location. It seems like we should all a search
to be done for it in which case the generate code would just start the command
line with "robocopy".
> CI failure (windows):
> org.apache.geode.internal.cache.persistence.BackupInspectorJUnitTest.testIncrementalBackupScript
> ----------------------------------------------------------------------------------------------------------------------
>
> Key: GEODE-3187
> URL: https://issues.apache.org/jira/browse/GEODE-3187
> Project: Geode
> Issue Type: Bug
> Components: persistence
> Reporter: Lynn Gallinat
>
> {noformat}
> org.apache.geode.internal.cache.persistence.BackupInspectorJUnitTest >
> testIncrementalBackupScript FAILED
> java.lang.AssertionError
> at org.junit.Assert.fail(Assert.java:86)
> at org.junit.Assert.assertTrue(Assert.java:41)
> at org.junit.Assert.assertTrue(Assert.java:52)
> at
> org.apache.geode.internal.cache.persistence.BackupInspectorJUnitTest.testIncrementalBackupScript(BackupInspectorJUnitTest.java:198)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
