[
https://issues.apache.org/jira/browse/GEODE-3198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16087723#comment-16087723
]
ASF GitHub Bot commented on GEODE-3198:
---------------------------------------
GitHub user nreich opened a pull request:
https://github.com/apache/geode/pull/636
GEODE-3198: Allow bucket creation when over local-max-memory
* the bucket will not be created on a member that is over local max
* memory, unless all members have failed to create the bucket and
* a "force" flag is set to true in the call to ensure bucket creation
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [x] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [x] Is your initial contribution a single, squashed commit?
- [x] Does `gradlew build` run cleanly?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to [email protected].
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nreich/geode feature/GEODE-3198
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/636.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #636
----
commit 6a29c6ed4392fcc43b82dc3d0554d0107722b4fc
Author: Nick Reich <[email protected]>
Date: 2017-07-14T18:09:31Z
GEODE-3198: Allow bucket creation when over local-max-memory
* the bucket will not be created on a member that is over local max
* memory, unless all members have failed to create the bucket and
* a "force" flag is set to true in the call to ensure bucket creation
----
> Do not prevent bucket creation if local-max-memory is exceeded
> --------------------------------------------------------------
>
> Key: GEODE-3198
> URL: https://issues.apache.org/jira/browse/GEODE-3198
> Project: Geode
> Issue Type: Improvement
> Reporter: Nick Reich
> Assignee: Nick Reich
>
> In creating a new bucket, if local-max-memory is exceeded on all members, the
> bucket cannot be created until a member goes below that memory threshold
> (which may be never, in which case the attempt to create the bucket loops
> forever). Currently, if all members have indicated they should not make the
> bucket, the request is again made, but with a "force" flag set to true. This
> allows overriding the fact that the member believes it already hosts as many
> buckets as it should for balance, but does not override the local-max-memory
> check. We should therefore have the force flag also override the memory
> threshold check, thus allowing bucket creation to proceed, but still
> attempting to honor not adding it to a member already at or above its target
> memory limit.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
