[
https://issues.apache.org/jira/browse/GEODE-3199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16084850#comment-16084850
]
ASF GitHub Bot commented on GEODE-3199:
---------------------------------------
Github user metatype commented on a diff in the pull request:
https://github.com/apache/geode-examples/pull/9#discussion_r127090456
--- Diff: gradle/release.gradle ---
@@ -41,17 +41,19 @@ gradle.taskGraph.whenReady( { graph ->
})
gradle.taskGraph.whenReady { taskGraph ->
- if (!version.endsWith('SNAPSHOT')) {
- if(!project.hasProperty('signing.keyId') ||
!project.hasProperty('signing.secretKeyRingFile')) {
- println "You must configure your signing.keyId and
signing.secretKeyRingFile"
- println "in ~/.gradle/gradle.properties in order to sign jars\n"
- println "See
https://cwiki.apache.org/confluence/display/GEODE/Release+Steps";
- throw new GradleException("Signing key/keyring is missing")
- }
+ if (project.hasProperty('askpass')) {
--- End diff --
Should this be called `signReleaseArtifacts` since it guards signing (which
may cause the password dialog to appear depending on your environment)?
> geode-examples on the release branch prompts for a gpg password
> ---------------------------------------------------------------
>
> Key: GEODE-3199
> URL: https://issues.apache.org/jira/browse/GEODE-3199
> Project: Geode
> Issue Type: Bug
> Components: build
> Reporter: Dan Smith
>
> When building geode-examples using ./gradlew build from the release/1.2.0
> branch, I get prompted to enter my gpg password. Since our instructions on
> running the examples tell the user to run gradlew build, they will hit this
> prompt when building the released examples.
> Travis is also showing this failure:
> https://travis-ci.org/apache/geode-examples/builds/244002605
> {noformat}
> You must configure your signing.keyId and signing.secretKeyRingFile
> in ~/.gradle/gradle.properties in order to sign jars
> See https://cwiki.apache.org/confluence/display/GEODE/Release+Steps
> FAILURE: Build failed with an exception.
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
