[ 
https://issues.apache.org/jira/browse/GEODE-3195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16084713#comment-16084713
 ] 

ASF GitHub Bot commented on GEODE-3195:
---------------------------------------

Github user metatype commented on a diff in the pull request:

    https://github.com/apache/geode-examples/pull/8#discussion_r127074639
  
    --- Diff: 
queries/src/main/java/org/apache/geode/examples/queries/Example.java ---
    @@ -0,0 +1,129 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
    + * agreements. See the NOTICE file distributed with this work for 
additional information regarding
    + * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance with the 
License. You may obtain a
    + * copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software 
distributed under the License
    + * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF 
ANY KIND, either express
    + * or implied. See the License for the specific language governing 
permissions and limitations under
    + * the License.
    + */
    +package org.apache.geode.examples.queries;
    +
    +import java.util.function.Consumer;
    +import java.util.Iterator;
    +
    +import org.apache.geode.cache.Region;
    +import org.apache.geode.cache.client.ClientCache;
    +import org.apache.geode.cache.client.ClientCacheFactory;
    +import org.apache.geode.cache.client.ClientRegionShortcut;
    +import org.apache.geode.cache.query.Query;
    +import org.apache.geode.cache.query.QueryService;
    +import org.apache.geode.cache.query.SelectResults;
    +
    +
    +public class Example implements Consumer<Region<Integer, EmployeeData>> {
    +  public static void main(String[] args) {
    +    // connect to the locator using default port 10334
    +    ClientCache cache = new 
ClientCacheFactory().addPoolLocator("127.0.0.1", 10334)
    +        .set("log-level", "WARN").create();
    +
    +    // create a local region that matches the server region
    +    Region<Integer, EmployeeData> region =
    +        cache.<Integer, 
EmployeeData>createClientRegionFactory(ClientRegionShortcut.CACHING_PROXY)
    +            .create("example-region");
    +
    +    Example e = new Example();
    +    e.accept(region);
    +    e.doQueries(cache, region);
    --- End diff --
    
    I think `doQueries` should be called from `accept` to make it easier to 
unit test the code.


> Create new geode-example about querying
> ---------------------------------------
>
>                 Key: GEODE-3195
>                 URL: https://issues.apache.org/jira/browse/GEODE-3195
>             Project: Geode
>          Issue Type: New Feature
>          Components: querying
>            Reporter: Karen Smoler Miller
>            Assignee: Karen Smoler Miller
>
> The more examples, the better. . .
> Create an example that demonstrates how to do some simple OQL queries.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to