[
https://issues.apache.org/jira/browse/GEODE-2161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15716748#comment-15716748
]
ASF subversion and git services commented on GEODE-2161:
--------------------------------------------------------
Commit 7aae4be31c809fbc62b8376399e09a0c978f0056 in incubator-geode's branch
refs/heads/develop from zhouxh
[ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=7aae4be ]
GEODE-2161: also need to fix the junit test for serialization comparison.
> FilterRoutingInfo.FilterInfo.toData does unneeded copying
> ---------------------------------------------------------
>
> Key: GEODE-2161
> URL: https://issues.apache.org/jira/browse/GEODE-2161
> Project: Geode
> Issue Type: Bug
> Reporter: xiaojian zhou
> Assignee: xiaojian zhou
>
> This is #52614
> FilterInfo.toData (that was being optimized for murex) does this:
> // create a hdos
> // write a bunch of stuff to it
> byte[] myData = hdos.toByteArray();
> DataSerializer.writeByteArray(myData, out);
> he toByteArray allocates a new byte array and copies all the data in the hdos
> to it.
> Then writeByteArray writes it all to "out".
> We can do this instead:
> if (out instanceof HeapDataOutputStream) {
> out.writeAsSerializedByteArray(hdos);
> } else {
> .. do it the old way
> }
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
