fresh-borzoni commented on code in PR #2989:
URL: https://github.com/apache/fluss/pull/2989#discussion_r3035400580
##########
fluss-filesystems/fluss-fs-s3/src/main/java/org/apache/fluss/fs/s3/token/S3DelegationTokenProvider.java:
##########
@@ -89,6 +112,23 @@ public ObtainedSecurityToken obtainSecurityToken() {
scheme, toJson(credentials),
credentials.getExpiration().getTime(), additionInfos);
}
+ private AWSSecurityTokenService buildStsClient() {
+ AWSSecurityTokenServiceClientBuilder builder =
+ AWSSecurityTokenServiceClientBuilder.standard()
+ .withCredentials(
+ new AWSStaticCredentialsProvider(
+ new BasicAWSCredentials(accessKey,
secretKey)));
Review Comment:
The existing code doesn't validate these either - out of scope.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
