wuchong commented on code in PR #2951: URL: https://github.com/apache/fluss/pull/2951#discussion_r3029601036
########## fluss-common/src/main/java/org/apache/fluss/record/ArrowNullCountReader.java: ########## @@ -0,0 +1,167 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.fluss.record; + +import org.apache.fluss.shaded.arrow.org.apache.arrow.flatbuf.FieldNode; +import org.apache.fluss.shaded.arrow.org.apache.arrow.flatbuf.Message; +import org.apache.fluss.shaded.arrow.org.apache.arrow.flatbuf.RecordBatch; +import org.apache.fluss.shaded.arrow.org.apache.arrow.vector.types.pojo.Field; +import org.apache.fluss.shaded.arrow.org.apache.arrow.vector.types.pojo.Schema; +import org.apache.fluss.shaded.guava32.com.google.common.cache.Cache; +import org.apache.fluss.shaded.guava32.com.google.common.cache.CacheBuilder; +import org.apache.fluss.types.RowType; +import org.apache.fluss.utils.ArrowUtils; + +import java.nio.ByteBuffer; +import java.nio.ByteOrder; +import java.time.Duration; +import java.util.Arrays; +import java.util.List; +import java.util.Objects; + +/** + * Utility for extracting null counts from Arrow RecordBatch FlatBuffer metadata. Used by both + * FileChannelLogRecordBatch and DefaultLogRecordBatch to read null counts from Arrow metadata + * instead of the statistics binary format (V2). + */ +class ArrowNullCountReader { Review Comment: Could you revert the commit of `get null count from arrow meta`, this pull request has already been very large. I think we can review this in an separate pull request. Besides, I have some concerns on the cache and deserialization performance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
