vaibhavk1992 commented on issue #2007:
URL: https://github.com/apache/fluss/issues/2007#issuecomment-4176456526
@LiebingYu
Thanks for assigning this to me! Really appreciate the thorough audit in
the issue description—makes it much easier to tackle systematically.
### Approach
I'm planning to categorize the fixes into **two phases**:
**Phase 1: External RPCs** (client-facing metadata operations)
`databaseExists`, `tableExists`, `getTableSchema`, `getLatestKvSnapshots`,
`getKvSnapshotMetadata`, `listPartitionInfos`, `getLatestLakeSnapshot`,
`listOffsets`
→ Add `authorizer.authorize(session, DESCRIBE, resource)` checks following
the
pattern in `createDatabase()`.
**Phase 2: Internal RPCs** (server-to-server coordination)
`adjustIsr`, `commitKvSnapshot`, `notifyLeaderAndIsr`, `updateMetadata`,
etc.
→ These need both authorization checks + validation that
`session.isInternal()` is
true to prevent external clients from calling internal APIs.
### Quick Questions
- Any prior discussions, design docs, or reference PRs I should review?
- Preferred pattern for internal RPC auth? Should I follow a specific "OK"
RPC as a
template?
- Existing test patterns for unauthorized access scenarios?
Happy to adjust the approach based on feedback!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
