Copilot commented on code in PR #2973:
URL: https://github.com/apache/fluss/pull/2973#discussion_r3019549820
##########
fluss-server/src/main/java/org/apache/fluss/server/coordinator/MetadataManager.java:
##########
@@ -513,6 +514,26 @@ public void alterTableProperties(
getUpdatedTableDescriptor(tableDescriptor,
tablePropertyChanges);
if (newDescriptor != null) {
+ // is to enable datalake for the table
+ if (isDataLakeEnabled(newDescriptor) &&
!isDataLakeEnabled(tableDescriptor)) {
+ // the table is created before the cluster enable datalake,
+ // we need backfill the datalake format to the table for
the case
+ // that is to enable datalake for the table
+ if
(!tableInfo.getTableConfig().getDataLakeFormat().isPresent()) {
+ DataLakeFormat dataLakeFormat =
Review Comment:
The newly added inline comments have several grammatical issues (e.g., “is
to enable datalake…”, “created before the cluster enable datalake”, “we need
backfill…”), which makes the intent harder to read. Please rewrite these
comments in clear, grammatically correct sentences (and preferably avoid
repeating the same phrase multiple times).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
