luoyuxia commented on code in PR #2933:
URL: https://github.com/apache/fluss/pull/2933#discussion_r3015408987
##########
fluss-common/src/main/java/org/apache/fluss/row/ProjectedRow.java:
##########
@@ -194,7 +194,14 @@ public static ProjectedRow from(Schema originSchema,
Schema expectedSchema) {
return new ProjectedRow(indexMapping);
}
- public int getSizeInBytes() {
+ /**
+ * Returns the on-wire size in bytes of the underlying raw row (before
projection), not the
+ * projected subset. This is used for byte-level metrics tracking where
the original record size
+ * is needed.
+ *
+ * @return the size in bytes of the underlying row, or -1 if unknown.
+ */
+ public int getUnderlyingRowSizeInBytes() {
Review Comment:
I'd like suggest to rename to getUnderlyingRow() and return row,
`getUnderlyingRowSizeInBytes` is to specific to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
