affo commented on code in PR #2947:
URL: https://github.com/apache/fluss/pull/2947#discussion_r3013977320
##########
fluss-filesystems/fluss-fs-azure/src/main/java/org/apache/fluss/fs/azure/token/AzureDelegationTokenReceiver.java:
##########
@@ -56,6 +56,11 @@ public static void
updateHadoopConfig(org.apache.hadoop.conf.Configuration hadoo
LOG.debug("Provider already exists");
}
+ // Tell the ABFS driver to use the custom token provider instead of
defaulting to SharedKey.
+ // DynamicTemporaryAzureCredentialsProvider implements
CustomTokenProviderAdaptee, which
+ // requires auth.type=Custom to be activated.
+ hadoopConfig.set("fs.azure.account.auth.type", "Custom");
Review Comment:
do you think this may be a problem?
AFAIK, it should not be, you can see `auth.type` as a setting that goes in
pair with `provider.type` above.
If the guard fails everything will fail -> which means we did not yet get
any token from the server side -> this problem is definitely out of scope of
this PR and potentially impacts any FS implementation in Fluss.
What we are doing here is adding that property to make FS init take into
consideration the actual custom Credentials provider that would never be used
otherwise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
