loserwang1024 commented on code in PR #2940:
URL: https://github.com/apache/fluss/pull/2940#discussion_r2998604003
##########
fluss-client/src/main/java/org/apache/fluss/client/write/DynamicPartitionCreator.java:
##########
@@ -121,14 +125,19 @@ private boolean
forceCheckPartitionExist(PhysicalTablePath physicalTablePath) {
return idExist;
}
- private void createPartition(PhysicalTablePath physicalTablePath,
List<String> partitionKeys) {
+ private void createPartition(
+ PhysicalTablePath physicalTablePath,
+ List<String> partitionKeys,
+ AutoPartitionStrategy autoPartitionStrategy) {
String partitionName = physicalTablePath.getPartitionName();
TablePath tablePath = physicalTablePath.getTablePath();
checkArgument(partitionName != null, "Partition name shouldn't be
null.");
ResolvedPartitionSpec resolvedPartitionSpec =
ResolvedPartitionSpec.fromPartitionName(partitionKeys,
partitionName);
+ PartitionSpec partitionSpec = resolvedPartitionSpec.toPartitionSpec();
+ validateAutoPartitionTime(partitionSpec, partitionKeys,
autoPartitionStrategy);
Review Comment:
It looks better. Just modified it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
