morazow commented on code in PR #2700:
URL: https://github.com/apache/fluss/pull/2700#discussion_r2997513934
##########
helm/templates/secret-jaas-config.yaml:
##########
@@ -16,20 +16,21 @@
# limitations under the License.
#
-{{ if (include "fluss.security.sasl.plain.enabled" .) }}
+{{ if (include "fluss.security.jaas.required" .) }}
{{- $internalMechanism := include "fluss.security.listener.mechanism" (dict
"context" .Values "listener" "internal") -}}
{{- $clientMechanism := include "fluss.security.listener.mechanism" (dict
"context" .Values "listener" "client") -}}
{{- $internalUsername := include "fluss.security.sasl.plain.internal.username"
. -}}
{{- $internalPassword := include "fluss.security.sasl.plain.internal.password"
. -}}
apiVersion: v1
kind: Secret
metadata:
- name: {{ include "fluss.security.sasl.configName" . }}
+ name: {{ include "fluss.security.jaas.configName" . }}
labels:
{{- include "fluss.labels" . | nindent 4 }}
type: Opaque
stringData:
jaas.conf: |
+{{- if (include "fluss.security.sasl.plain.enabled" .) }}
Review Comment:
Hello @affo ,
Are you referring to this line:
```
{{- if eq $internalMechanism "plain" }}
```
If so, yes this is to distinguish internal and client listener mechanisms.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
