leekeiabstraction commented on code in PR #2881:
URL: https://github.com/apache/fluss/pull/2881#discussion_r2991326712
##########
fluss-lake/fluss-lake-iceberg/src/main/java/org/apache/fluss/lake/iceberg/tiering/IcebergLakeCommitter.java:
##########
@@ -262,6 +279,22 @@ public void close() throws Exception {
}
}
+ /**
+ * Expires old snapshots from the Iceberg table. Uses Iceberg's built-in
snapshot expiration
+ * which respects table properties like {@code
history.expire.max-snapshot-age-ms} and {@code
+ * history.expire.min-snapshots-to-keep}.
+ */
+ private void expireSnapshots() {
+ try {
+ ExpireSnapshots expireSnapshots =
+ icebergTable.expireSnapshots().cleanExpiredFiles(true);
Review Comment:
Does this expire all non latest snapshots? If so, would this cause recovery
failure in the case when tiering service failover and restarts from latest
Flink checkpoint and couldn't find a deleted iceberg snapshot?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
