affo commented on code in PR #2871:
URL: https://github.com/apache/fluss/pull/2871#discussion_r2939724755
##########
.github/workflows/helm-chart.yaml:
##########
@@ -44,6 +44,17 @@ jobs:
- name: "Checkout code"
uses: actions/checkout@v6
+ - name: Set up Python
+ uses: actions/setup-python@v5
+ with:
+ python-version: "3.11"
+
+ - name: Install dependencies
+ run: pip install jsonschema==4.26.0 PyYAML==6.0.3
+
+ - name: Run unstable test reporter
Review Comment:
```suggestion
- name: Validate values
```
##########
.github/workflows/helm-chart.yaml:
##########
@@ -44,6 +44,17 @@ jobs:
- name: "Checkout code"
uses: actions/checkout@v6
+ - name: Set up Python
+ uses: actions/setup-python@v5
+ with:
+ python-version: "3.11"
Review Comment:
```suggestion
python-version: "3.12"
```
Just better to point to that one if we don't break anything
##########
tools/ci/helm_ci/validate_helm.py:
##########
@@ -0,0 +1,89 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Review Comment:
Why do we need this script ?
Isn't `helm lint` already picking `values.schema.json` for validation?
Is this only for the meta schema?
##########
.github/workflows/helm-chart.yaml:
##########
@@ -44,6 +44,17 @@ jobs:
- name: "Checkout code"
uses: actions/checkout@v6
+ - name: Set up Python
+ uses: actions/setup-python@v5
+ with:
+ python-version: "3.11"
+
+ - name: Install dependencies
+ run: pip install jsonschema==4.26.0 PyYAML==6.0.3
Review Comment:
I would favor a `requirements.txt` under `tools/ci/helm_ci`.
It would make it easier to validate locally.
The command would become `pip install -r tools/ci/helm_ci/requirements.txt`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
