swuferhong commented on code in PR #2883:
URL: https://github.com/apache/fluss/pull/2883#discussion_r2939754088
##########
fluss-client/src/test/java/org/apache/fluss/client/admin/FlussAdminITCase.java:
##########
@@ -1625,22 +1610,17 @@ public void testAddAndRemoveServerTags() throws
Exception {
.containsEntry(0, ServerTag.PERMANENT_OFFLINE)
.containsEntry(1, ServerTag.PERMANENT_OFFLINE);
- // 4.remove server tag for server 100
- assertThatThrownBy(
- () ->
- admin.removeServerTag(
- Collections.singletonList(100),
- ServerTag.PERMANENT_OFFLINE)
- .get())
- .cause()
- .isInstanceOf(ServerNotExistException.class)
- .hasMessageContaining("Server 100 not exists when trying to
removing server tag.");
-
- // 5.remove server tag for server 0,1.
+ // 4.remove server tag for server 0,1.
+ // should remove server tag successfully even we remove live tablet
server from context
+ FLUSS_CLUSTER_EXTENSION
+ .getCoordinatorServer()
+ .getCoordinatorEventProcessor()
+ .getCoordinatorContext()
+ .removeLiveTabletServer(0);
Review Comment:
This test does not cover the case where this `serverTag` exists in zk but
the server is already offline. The remove operation can remove the record from
zk. please adding that test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
