vamossagar12 opened a new pull request, #2876:
URL: https://github.com/apache/fluss/pull/2876
<!--
*Thank you very much for contributing to Fluss - we are happy that you want
to help us improve Fluss. To help the community review your contribution in the
best possible way, please go through the checklist below, which will get the
contribution into a shape in which it can be best reviewed.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [GitHub
issue](https://github.com/apache/fluss/issues). Exceptions are made for typos
in JavaDoc or documentation files, which need no issue.
- Name the pull request in the format "[component] Title of the pull
request", where *[component]* should be replaced by the name of the component
being changed. Typically, this corresponds to the component label assigned to
the issue (e.g., [kv], [log], [client], [flink]). Skip *[component]* if you are
unsure about which is the best component.
- Fill out the template below to describe the changes contributed by the
pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean
verify` passes.
- Each pull request should address only one issue, not mix up code from
multiple issues.
**(The sections below can be removed for hotfixes or typos)**
-->
### Purpose
<!-- Linking this pull request to the issue -->
Linked issue: close #2397
<!-- What is the purpose of the change -->
### Brief change log
[FLUSS-2397] Fix UPDATE failure for primary key tables with computed columns
This commit fixes a bug where UPDATE statements failed when target tables
contained computed columns (e.g., PROCTIME). The root cause was that the
SinkWriter was using the table's physical RowType to initialize the
serialization schema, rather than the "consumed" RowType which includes
computed/metadata columns.
Key changes:
- Introduced 'consumedRowType' in FlinkSinkWriter, AppendSinkWriter, and
UpsertSinkWriter to properly handle schema projection during serialization.
- Updated FlinkTableSink to ensure the correct row type is passed down to
the writer.
- Added a regression test in FlinkTableSinkITCase that reproduces the
reported failure (Bug #2397).
- Updated internal builders and tests to accommodate the schema context.
### Tests
<!-- List UT and IT cases to verify this change -->
fluss-flink/fluss-flink-common/src/test/java/org/apache/fluss/flink/sink/FlinkTableSinkITCase.java
### API and Format
N/A
### Documentation
N/A
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]