fresh-borzoni commented on code in PR #438:
URL: https://github.com/apache/fluss-rust/pull/438#discussion_r2935486556
##########
bindings/python/test/test_log_table.py:
##########
@@ -729,6 +729,923 @@ async def
test_scan_records_indexing_and_slicing(connection, admin):
await admin.drop_table(table_path, ignore_if_not_exists=False)
+async def test_async_iterator(connection, admin):
Review Comment:
Can we reduce the amount of tests?
- Keep tests that cover the async for happy path, break safety, and
multiple poll cycles
- Drop tests for _async_poll / _async_poll_batches directly - they're
internal methods, tested implicitly through async for
- Drop tests that re-verify existing features (projection, pandas,
metadata) through the async path - those features are already covered by sync
tests
##########
bindings/python/src/table.rs:
##########
@@ -30,6 +30,7 @@ use pyo3::types::{
PyDeltaAccess, PyDict, PyList, PySequence, PySlice, PyTime, PyTimeAccess,
PyTuple, PyType,
PyTzInfo,
};
+use pyo3::{Bound, IntoPyObjectExt, Py, PyAny, PyRef, PyRefMut, PyResult,
Python};
Review Comment:
Do we really need these?
Seems that it's a leftover and we only need 1-2 objects, maybe only
`IntoPyObjectExt`
##########
bindings/python/src/table.rs:
##########
@@ -2199,6 +2200,171 @@ impl LogScanner {
Ok(df)
}
+ fn __aiter__<'py>(slf: PyRef<'py, Self>) -> PyResult<Bound<'py, PyAny>> {
Review Comment:
we need to add this method to .pyi stubs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
