fresh-borzoni commented on code in PR #369:
URL: https://github.com/apache/fluss-rust/pull/369#discussion_r2935343121
##########
crates/examples/src/example_partitioned_kv_table.rs:
##########
@@ -129,7 +130,7 @@ pub async fn main() -> Result<()> {
Ok(())
}
-async fn create_partition(table_path: &TablePath, admin: &mut FlussAdmin,
region: &str, zone: i64) {
+async fn create_partition(table_path: &TablePath, admin: &Arc<FlussAdmin>,
region: &str, zone: i64) {
Review Comment:
why not &FlussAdmin?
##########
bindings/python/test/conftest.py:
##########
@@ -92,6 +92,32 @@ def _run_cmd(cmd):
return subprocess.run(cmd, capture_output=True).returncode
+def _wait_for_coordinator_ready(host, port, timeout=60):
Review Comment:
tbh, this is not necessary for python, we have `_connect_with_retry`
##########
crates/fluss/tests/integration/utils.rs:
##########
@@ -109,7 +109,8 @@ pub async fn wait_for_cluster_ready_with_sasl(cluster:
&FlussTestingCluster) {
let connection = cluster
.get_fluss_connection_with_sasl(username, password)
.await;
- if connection.get_admin().await.is_ok()
Review Comment:
I think we shall just remove this check and rely on
`get_one_available_server()` later
##########
bindings/python/test/conftest.py:
##########
@@ -92,6 +92,32 @@ def _run_cmd(cmd):
return subprocess.run(cmd, capture_output=True).returncode
+def _wait_for_coordinator_ready(host, port, timeout=60):
+ """Poll list_databases() until the CoordinatorEventProcessor is ready."""
+ start = time.time()
+ while time.time() - start < timeout:
+ try:
+ async def _probe():
Review Comment:
it's wasteful to redefine on every loop iteration
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
