hemanthsavasere opened a new pull request, #2870:
URL: https://github.com/apache/fluss/pull/2870

   ### Purpose
   
   Linked issue: close #2191
   
   The Fluss Helm chart had hardcoded values for replica counts, 
liveness/readiness probe settings, and resource limits for both 
CoordinatorServer and TabletServer. This made it impossible to tune health 
probe timings or scale components without directly modifying the chart 
templates.
   
   This PR consolidates all per-component configuration under the existing 
`coordinator` and `tablet` top-level sections in `values.yaml`, adding 
`replicas`, `livenessProbe`, `readinessProbe`, and `resources` fields to each. 
The StatefulSet templates are updated to reference these configurable values 
instead of hardcoded constants.
   
   ### Brief change log
   
   - **`helm/values.yaml`**: Added `replicas`, `livenessProbe`, 
`readinessProbe`, and `resources` fields under the existing `coordinator` and 
`tablet` sections. Removed the top-level `resources` section (which had 
`coordinatorServer`/`tabletServer` sub-keys) in favor of co-locating resource 
config with each component.
   - **`helm/templates/sts-coordinator.yaml`**: Replaced hardcoded `replicas: 
1` and hardcoded probe settings with references to 
`.Values.coordinator.replicas`, `.Values.coordinator.livenessProbe.*`, 
`.Values.coordinator.readinessProbe.*`, and `.Values.coordinator.resources`.
   - **`helm/templates/sts-tablet.yaml`**: Replaced hardcoded `replicas: 3` and 
hardcoded probe settings with references to `.Values.tablet.replicas`, 
`.Values.tablet.livenessProbe.*`, `.Values.tablet.readinessProbe.*`, and 
`.Values.tablet.resources`.
   
   Default values match the previously hardcoded constants, so existing 
deployments using default values are unaffected.
   
   ### Tests
   
   - `helm template test ./helm` — verifies templates render without errors
   - `helm lint ./helm` — verifies chart passes linting
   - Manual: `helm template test ./helm --set coordinator.replicas=2 --set 
tablet.replicas=5` to verify custom values are applied correctly
   
   ### API and Format
   
   No changes to Fluss server API or storage format. This is a Helm chart 
configuration change only.
   
   ### Documentation
   
   No new Fluss feature is introduced. The change is self-documenting via the 
updated `values.yaml` defaults and comments.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to