charlesdong1991 commented on code in PR #399:
URL: https://github.com/apache/fluss-rust/pull/399#discussion_r2926398063
##########
crates/fluss/src/rpc/server_connection.rs:
##########
@@ -301,9 +325,9 @@ where
match map.remove(&header.request_id) {
Some(active_request) => active_request,
_ => {
- log::warn!(
+ log::debug!(
Review Comment:
i think debug fits better here: because this is a normal late-response race
after timeout/cancel, other than an operational warning IMHO
so in production environment, we probably will use metric/counter which
probably better than warn spamming. WDYT? @luoyuxia
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
