luoyuxia commented on PR #2842: URL: https://github.com/apache/fluss/pull/2842#issuecomment-4043448531
> Should we also check if this needs to be fixed? > > https://github.com/apache/fluss/blob/dd181eb24ac4e536a50e593992a1d467823a50b9/fluss-lake/fluss-lake-iceberg/src/main/java/org/apache/fluss/lake/iceberg/maintenance/IcebergRewriteDataFiles.java#L91 The code must keep includeColumnStats() because sortFileScanTask() at line 122-138 directly reads f1.file().lowerBounds().get(sortFiledId) to sort files by the __offset column. Removing includeColumnStats() there would cause lowerBounds() to return null, resulting in an NPE -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
