LiebingYu commented on code in PR #2799:
URL: https://github.com/apache/fluss/pull/2799#discussion_r2903044407
##########
fluss-lake/fluss-lake-paimon/src/main/java/org/apache/fluss/lake/paimon/utils/PaimonConversions.java:
##########
@@ -275,6 +274,14 @@ private static void validatePaimonOptions(Map<String,
String> properties) {
});
}
+ private static void validateAlterPaimonOptions(String key) {
+ if (PAIMON_UNSETTABLE_OPTIONS.contains(key)
+ || CoreOptions.IMMUTABLE_OPTIONS.contains(key)) {
Review Comment:
Currently, Flink doesn't support to alter `bucket.num`.
If we support to alter `bucket.num` in the future, we should change
`PAIMON_UNSETTABLE_OPTIONS ` to `PAIMON_UNALTERABLE_OPTIONS` here (because
`bucket` exists in `PAIMON_UNSETTABLE_OPTIONS `). But I think we ok to use
`PAIMON_UNSETTABLE_OPTIONS ` here for now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
