gyang94 commented on code in PR #2782:
URL: https://github.com/apache/fluss/pull/2782#discussion_r2901764576
##########
fluss-common/src/main/java/org/apache/fluss/remote/RemoteLogSegment.java:
##########
@@ -50,14 +51,17 @@ public class RemoteLogSegment {
private final int segmentSizeInBytes;
+ private final FsPath remoteLogDir;
+
private RemoteLogSegment(
PhysicalTablePath physicalTablePath,
TableBucket tableBucket,
UUID remoteLogSegmentId,
long remoteLogStartOffset,
long remoteLogEndOffset,
long maxTimestamp,
- int segmentSizeInBytes) {
+ int segmentSizeInBytes,
+ FsPath remoteLogDir) {
Review Comment:
similarly, is it good to put remoteLogDir into physicalTablePath?
I find that every time when we need to add a 'remoteLogDir' parameter for
functions or constructors, there are always a TablePath/PhysicalTablePath
parameters existed.
Maybe we can carry remoteLogDir inside these two classes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
