fresh-borzoni commented on code in PR #435:
URL: https://github.com/apache/fluss-rust/pull/435#discussion_r2901713733
##########
bindings/python/test/conftest.py:
##########
@@ -112,42 +145,121 @@ def fluss_cluster():
"netty.server.num-network-threads: 1",
"netty.server.num-worker-threads: 3",
])
+
+ zookeeper = (
+ DockerContainer("zookeeper:3.9.2")
+ .with_kwargs(network=NETWORK_NAME)
+ .with_name(ZOOKEEPER_NAME)
+ )
+ coordinator = (
+ DockerContainer(f"{FLUSS_IMAGE}:{FLUSS_VERSION}")
+ .with_kwargs(network=NETWORK_NAME)
+ .with_name(COORDINATOR_NAME)
+ .with_bind_ports(9123, 9123)
+ .with_bind_ports(9223, 9223)
+ .with_command("coordinatorServer")
+ .with_env("FLUSS_PROPERTIES", coordinator_props)
+ )
tablet_server = (
DockerContainer(f"{FLUSS_IMAGE}:{FLUSS_VERSION}")
- .with_network(network)
- .with_name("tablet-server-python-test")
+ .with_kwargs(network=NETWORK_NAME)
+ .with_name(TABLET_SERVER_NAME)
.with_bind_ports(9123, 9124)
.with_bind_ports(9223, 9224)
.with_command("tabletServer")
.with_env("FLUSS_PROPERTIES", tablet_props)
)
- zookeeper.start()
- coordinator.start()
- tablet_server.start()
+ try:
+ zookeeper.start()
+ coordinator.start()
+ tablet_server.start()
+ except Exception as e:
Review Comment:
Good call 👍
file lock approcach is cleaner, but it requires more restructuring, so I
just used the same approach as in cpp for consistency.
Let's create follow up if someone wishes to improve this and play with XDIST.
I don't expect tests time to change though :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
