XiaoHongbo-Hope commented on code in PR #436:
URL: https://github.com/apache/fluss-rust/pull/436#discussion_r2901671459


##########
bindings/python/src/metadata.rs:
##########
@@ -220,7 +220,12 @@ impl Schema {
             .collect()
     }
 

Review Comment:
   > `Schema.get_primary_keys()` is missing a Rust doc comment (`/// ...`) 
while the adjacent Schema methods have doc comments. Adding one keeps the 
generated Python docstrings/help output consistent across the API surface.
   > 
   > Suggested change
   >     /// Get primary key column names
   
   Added



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to