fresh-borzoni commented on code in PR #428:
URL: https://github.com/apache/fluss-rust/pull/428#discussion_r2899711707
##########
crates/fluss/src/metadata/datatype.rs:
##########
@@ -1171,6 +1259,7 @@ pub struct DataField {
pub name: String,
pub data_type: DataType,
pub description: Option<String>,
+ pub field_id: i32,
Review Comment:
Derived PartialEq/Hash now includes field_id, Java explicitly excludes it.
This silently breaks equality
##########
crates/fluss/src/metadata/datatype.rs:
##########
@@ -1193,6 +1297,10 @@ impl DataField {
pub fn data_type(&self) -> &DataType {
&self.data_type
}
+
+ pub fn field_id(&self) -> i32 {
Review Comment:
this needs full wiring, JSON serde doesn't read/write field_id yet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
