rionmonster commented on code in PR #27598:
URL: https://github.com/apache/flink/pull/27598#discussion_r2806190108
##########
flink-runtime/src/main/java/org/apache/flink/streaming/runtime/operators/sink/GlobalCommitterSerializer.java:
##########
@@ -105,7 +105,7 @@ private GlobalCommittableWrapper<CommT, GlobalCommT>
deserializeV1(DataInputView
SinkV1CommittableDeserializer.readVersionAndDeserializeList(
globalCommittableSerializer, in);
return new GlobalCommittableWrapper<>(
- new CommittableCollector<>(metricGroup), globalCommittables);
+ new CommittableCollector<>(metricGroup, true),
globalCommittables);
Review Comment:
In this case, I think that `false` is correct here for consistency, but it's
unlikely to be called anyways (except for state being restored by an older
version (e.g., a Flink job using the older SinkV1 APIs).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
