Efrat19 commented on code in PR #27440:
URL: https://github.com/apache/flink/pull/27440#discussion_r2797569835
##########
flink-runtime/src/test/java/org/apache/flink/streaming/api/operators/SourceOperatorTest.java:
##########
@@ -44,38 +50,50 @@ Licensed to the Apache Software Foundation (ASF) under one
import org.apache.flink.streaming.runtime.watermarkstatus.WatermarkStatus;
import org.apache.flink.streaming.util.CollectorOutput;
import org.apache.flink.streaming.util.MockOutput;
+import org.apache.flink.testutils.junit.extensions.parameterized.Parameter;
+import
org.apache.flink.testutils.junit.extensions.parameterized.ParameterizedTestExtension;
+import org.apache.flink.testutils.junit.extensions.parameterized.Parameters;
import org.apache.flink.util.CollectionUtil;
import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.BeforeEach;
-import org.junit.jupiter.api.Test;
-import org.junit.jupiter.params.ParameterizedTest;
-import org.junit.jupiter.params.provider.ValueSource;
+import org.junit.jupiter.api.TestTemplate;
+import org.junit.jupiter.api.extension.ExtendWith;
import javax.annotation.Nullable;
import java.util.ArrayList;
import java.util.Arrays;
+import java.util.Collection;
import java.util.Collections;
import java.util.List;
import java.util.concurrent.CompletableFuture;
+import static java.util.Collections.singletonMap;
import static org.assertj.core.api.Assertions.assertThat;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertNotNull;
/** Unit test for {@link SourceOperator}. */
@SuppressWarnings("serial")
+@ExtendWith(ParameterizedTestExtension.class)
class SourceOperatorTest {
@Nullable private SourceOperatorTestContext context;
@Nullable private SourceOperator<Integer, MockSourceSplit> operator;
@Nullable private MockSourceReader mockSourceReader;
@Nullable private MockOperatorEventGateway mockGateway;
+ @Parameters(name = "pauseSourcesUntilCheckpoint = {0}")
+ public static Collection<Boolean> parameters() {
+ return Arrays.asList(true, false);
+ }
+
+ @Parameter public boolean pauseSourcesUntilCheckpoint;
Review Comment:
nit property declaration to precede method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
