featzhang commented on code in PR #27580:
URL: https://github.com/apache/flink/pull/27580#discussion_r2796372886
##########
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/AccessExecutionGraph.java:
##########
@@ -226,4 +227,11 @@ public interface AccessExecutionGraph extends
JobStatusProvider {
* @return ID of the application this job belongs to.
*/
Optional<ApplicationID> getApplicationId();
+
+ /***
+ * Get the rescale related configuration when using {@link
org.apache.flink.runtime.scheduler.adaptive.AdaptiveScheduler}.
+ * @return The rescale related configuration.
Review Comment:
The method is marked as @Nullable, but the contract does not clearly specify:
Under which scheduler modes this may return null
Whether REST handlers properly guard against null
This makes the API semantics unclear for callers:
`Returns null if the scheduler is not AdaptiveScheduler`.
##########
docs/static/generated/rest_v1_dispatcher.yml:
##########
@@ -2830,6 +2877,10 @@ components:
type: string
triggerId:
$ref: '#/components/schemas/TriggerId'
+ SchedulerExecutionMode:
+ type: string
+ enum:
+ - REACTIVE
Review Comment:
The enum currently contains only REACTIVE.
If future scheduler modes are added (e.g., ADAPTIVE_BATCH), this may create
REST compatibility constraints.
Please confirm whether this enum is intended to be strictly single-valued or
extensible.
##########
flink-runtime-web/src/test/resources/rest_api_v1.snapshot:
##########
@@ -4679,5 +4679,56 @@
}
}
}
+ }, {
+ "url" : "/jobs/:jobid/rescales/config",
+ "method" : "GET",
+ "status-code" : "200 OK",
+ "file-upload" : false,
+ "path-parameters" : {
+ "pathParameters" : [ {
+ "key" : "jobid"
+ } ]
+ },
+ "query-parameters" : {
+ "queryParameters" : [ ]
+ },
+ "request" : {
+ "type" : "object",
+ "id" :
"urn:jsonschema:org:apache:flink:runtime:rest:messages:EmptyRequestBody"
+ },
+ "response" : {
+ "type" : "object",
+ "id" :
"urn:jsonschema:org:apache:flink:runtime:rest:messages:ThreadDumpInfo",
Review Comment:
"id" :
"urn:jsonschema:org:apache:flink:runtime:rest:messages:job:rescales:JobRescaleConfigInfo",
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
