zentol commented on PR #22737: URL: https://github.com/apache/flink/pull/22737#issuecomment-1590635671
You can look at the commits in https://github.com/zentol/flink-ci-docker/commits/master. The last 4 commits are relevant for this upgrade. You can also check the layers in https://hub.docker.com/layers/chesnay/flink-ci/java_8_11_17_maven_386_v2/images/sha256-566fc00ee070850d47dc082e50bcdfbc7a07cea5b7bd3bc08c3943eba1cc9e4b?context=repo. > I understand that it means a bit of overhead for minor changes like that one. I think it's a bit more of a hindrance than you think. > (e.g. [apache/flink-docker](https://github.com/apache/flink-docker)?) It doesn't belong in flink-docker imo; should be a separate repo. (Ideally flink-docker is mostly merged into the flink repo eventually, only serving as a publishing area for official-images.) > (having explicit versions in the code that enable us to actual review such a change) I don't think the reviewability is impacted by this being in my own repo :thinking: > couldn't we use the Flink Docker registry for the CI Docker image as well We could, but then I have to ping someone else for making any change to the image because we don't have enough seats in the apache org. GHCR + GHA would make more sense, but we'd have to invest some time into setting things up. That being said, it's a reasonable idea, so feel free to file tickets to that end. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
