[
https://issues.apache.org/jira/browse/FINERACT-2577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18070681#comment-18070681
]
Ashhar Ahmad Khan commented on FINERACT-2577:
---------------------------------------------
Fix implemented across all 3 layers in PR #5733:
https://github.com/apache/fineract/pull/5733
PR #5732 was closed due to a branch rename. #5733 is the active PR.
> Allow adjust (modify) of Fixed Deposit transactions
> ---------------------------------------------------
>
> Key: FINERACT-2577
> URL: https://issues.apache.org/jira/browse/FINERACT-2577
> Project: Apache Fineract
> Issue Type: Bug
> Components: Savings
> Reporter: Ashhar Ahmad Khan
> Priority: Major
>
> Fixed Deposit accounts have a silently broken adjust (modify) transaction
> endpoint. The bug exists in the same 3-layer pattern as the undo bug fixed by
> PR #5590 (FINERACT-2463).
> Layer 1 - FixedDepositAccountTransactionsApiResource.java calls
> builder.adjustSavingsAccountTransaction() instead of an FD-specific method,
> so every modify request is routed to the SAVINGSACCOUNT command handler
> instead of FIXEDDEPOSITACCOUNT.
> Layer 2 - adjustFixedDepositAccountTransaction() does not exist in
> CommandWrapperBuilder.java. Only the savings and recurring deposit
> equivalents exist.
> Layer 3 - adjustFDTransaction() in
> DepositAccountWritePlatformServiceJpaRepositoryImpl.java is an unconditional
> stub that always throws DepositAccountTransactionNotAllowedException. Both
> parameters are marked @SuppressWarnings("unused"), confirming it was never
> implemented.
> FixedDepositTransactionAdjustmentCommandHandler is already correctly
> annotated with @CommandType(entity = "FIXEDDEPOSITACCOUNT", action =
> "ADJUSTTRANSACTION") and requires no changes. Fixing the 3 layers above makes
> it work automatically.
> *Steps to reproduce:* POST
> /v1/fixeddepositaccounts/\{id}/transactions/\{txnId}?command=modify on any
> active Fixed Deposit account.
> *Expected:* Transaction is adjusted and a new transaction is created with the
> updated amount.
> *Actual:* Request silently routes to the savings handler and fails.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
