DeathGun44 commented on code in PR #5711:
URL: https://github.com/apache/fineract/pull/5711#discussion_r3022149442
##########
fineract-charge/src/main/java/org/apache/fineract/portfolio/charge/exception/LoanChargeWaiveCannotBeReversedException.java:
##########
@@ -39,9 +39,9 @@ public String errorMessage() {
} else if (name().equalsIgnoreCase("ALREADY_WAIVED")) {
return "This loan charge has already been waived";
} else if (name().equalsIgnoreCase("LOAN_INACTIVE")) {
- return "This loan charge can be waived as the loan associated
with it is currently inactive";
+ return "This loan charge cannot be waived as the loan
associated with it is currently inactive";
Review Comment:
I think "This loan charge waive cannot be reversed as the loan associated
with it is currently inactive" would be better return statement wrt the name of
the class (reversing the waived charge).
##########
fineract-charge/src/main/java/org/apache/fineract/portfolio/charge/exception/LoanChargeWaiveCannotBeReversedException.java:
##########
@@ -39,9 +39,9 @@ public String errorMessage() {
} else if (name().equalsIgnoreCase("ALREADY_WAIVED")) {
return "This loan charge has already been waived";
} else if (name().equalsIgnoreCase("LOAN_INACTIVE")) {
- return "This loan charge can be waived as the loan associated
with it is currently inactive";
+ return "This loan charge cannot be waived as the loan
associated with it is currently inactive";
} else if
(name().equalsIgnoreCase("WAIVE_NOT_ALLOWED_FOR_CHARGE")) {
- return "This loan charge can be waived";
+ return "This loan charge cannot be waived";
Review Comment:
same here.. "This loan charge waive cannot be reversed".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
