pratikpatel-aurochs opened a new pull request, #5729:
URL: https://github.com/apache/fineract/pull/5729
## Description
`isPeriodContainsFeb29` in `ProgressiveEMICalculator` only checked the
`repaymentPeriodFromDate`'s year for leap year. A repayment period spanning
from a non-leap year into a leap year (e.g., Dec 1, 2023 → Mar 1, 2024)
returned `false` even though Feb 29, 2024 falls
within the period.
This caused two downstream issues for `FEB_29_PERIOD_ONLY` strategy:
- `numberOfDaysFeb29PeriodOnly` returned 365 instead of 366
- `partialPeriodCalculationNeeded` was `false`, skipping the
year-splitting interest calculation
**Fix:** Iterate all years the period spans and check each leap year's Feb
29 against the range.
**Impact:** Affects progressive loans using `ACTUAL` days-in-year +
`FEB_29_PERIOD_ONLY` with non-monthly repayment frequencies (bi-monthly,
quarterly) where a period crosses from a non-leap year past Feb 29 of the next
leap year. Monthly repayments are not affected.
## Checklist
Please make sure these boxes are checked before submitting your pull request
- thanks!
- [ ] Write the commit message as per [our
guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests)
- [ ] Acknowledge that we will not review PRs that are not passing the build
_("green")_ - it is your responsibility to get a proposed PR to pass the build,
not primarily the project's maintainers.
- [ ] Create/update [unit or integration
tests](https://fineract.apache.org/docs/current/#_testing) for verifying the
changes made.
- [ ] Follow our [coding
conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions).
- [ ] Add required Swagger annotation and update API documentation at
fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with
details of any API changes
- [ ] [This PR must not be a "code
dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit).
Large changes can be made in a branch, with assistance. Ask for help on the
[developer mailing list](https://fineract.apache.org/#contribute).
Your assigned reviewer(s) will follow our [guidelines for code
reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
