DeathGun44 commented on code in PR #5721:
URL: https://github.com/apache/fineract/pull/5721#discussion_r3014037306
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/service/LoanScheduleHistoryReadPlatformServiceImpl.java:
##########
@@ -59,12 +59,11 @@ public LoanScheduleHistoryReadPlatformServiceImpl(final
JdbcTemplate jdbcTemplat
this.jdbcTemplate = jdbcTemplate;
}
- @SuppressWarnings("deprecation")
@Override
public Integer fetchCurrentVersionNumber(Long loanId) {
final String sql = "select MAX(lrs.version) from
m_loan_repayment_schedule_history lrs where lrs.loan_id = ?";
Integer max = this.jdbcTemplate.queryForObject(sql, new Object[] {
loanId }, Integer.class);
Review Comment:
The jdbcTemplate.queryForObject(String, Object[], Class) method call is also
deprecated (since Spring 5.3). If we are removing
@SuppressWarnings("deprecation") ,please consider addressing that aswell!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
