Aman-Mittal commented on code in PR #5707:
URL: https://github.com/apache/fineract/pull/5707#discussion_r3013407227
##########
fineract-core/src/test/java/org/apache/fineract/infrastructure/core/service/IpAddressUtilsTest.java:
##########
@@ -34,14 +16,14 @@ void clearContext() {
RequestContextHolder.resetRequestAttributes();
}
- // Proper isolation helper
+ // Helper method for setting request context
private void withRequest(HttpServletRequest request, Runnable testLogic) {
ServletRequestAttributes attributes = new
ServletRequestAttributes(request);
try {
RequestContextHolder.setRequestAttributes(attributes);
testLogic.run();
} finally {
- RequestContextHolder.resetRequestAttributes(); // critical cleanup
Review Comment:
This Pr does not add any unit tests,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
